Use std::optional for peak fitting (which can fail) and other minor refactorings
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
* origin/lobis-option: [pre-commit.ci] auto fixes from pre-commit.com hooks # Conflicts: # src/TRestDetectorSignal.cxx
|
Some examples of TRestDetectorSignalEvents analyzed with a macro using TRestDetectorSignal::GetPeakGauss(): void DrawEvent(TRestDetectorSignalEvent* event, TCanvas* canvas) {
Int_t numberOfSignals = event->GetNumberOfSignals();
std::cout << "Number of signals in event: " << numberOfSignals << std::endl;
canvas->Clear();
TPad* pad = event->DrawEvent();
if (pad) {
pad->SetCanvas(canvas);
canvas->cd();
pad->Draw();
pad->cd();
} else {
std::cout << "Failed to draw event, pad is null." << std::endl;
}
for (int i = 0; i < numberOfSignals; i++) {
TRestDetectorSignal* signal = event->GetSignal(i);
std::optional<std::pair<Double_t, Double_t>> maxGaussOpt = signal->GetPeakGauss();
if (maxGaussOpt) {
auto maxGauss = maxGaussOpt.value();
std::cout << "Max peak for signal " << i << " : " << maxGauss.first << " " << maxGauss.second << std::endl;
TMarker* marker = new TMarker(maxGauss.first, maxGauss.second, 20);
marker->SetMarkerColor(2);
marker->Draw("same");
}
}
canvas->Update();
}20 ns of sampling time: 40 ns of sampling time: Another event: Also, I tried using Plotting the spectra (hitsAna_energy) with this branch and This branch:
|
mariajmz
reviewed
Jun 4, 2024
mariajmz
reviewed
Jun 4, 2024
mariajmz
reviewed
Jun 4, 2024
mariajmz
reviewed
Jun 4, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mariajmz
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New we skip the peak if it's not being found, instead of returning energy -1